github-actions[bot] commented on code in PR #25591:
URL: https://github.com/apache/doris/pull/25591#discussion_r1363600566
##########
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##########
@@ -440,27 +216,12 @@ struct AggregateJavaUdafData {
RETURN_IF_ERROR(register_id("merge", UDAF_EXECUTOR_MERGE_SIGNATURE,
executor_merge_id));
RETURN_IF_ERROR(
register_id("serialize", UDAF_EXECUTOR_SERIALIZE_SIGNATURE,
executor_serialize_id));
- RETURN_IF_ERROR(register_id("getValue", "(J)Ljava/lang/Object;",
executor_get_value_id));
+ RETURN_IF_ERROR(
+ register_id("getValue", UDAF_EXECUTOR_GET_SIGNATURE,
executor_get_value_id));
RETURN_IF_ERROR(
register_id("destroy", UDAF_EXECUTOR_DESTROY_SIGNATURE,
executor_destroy_id));
- RETURN_IF_ERROR(register_id("convertBasicArguments",
"(IZIIJJJ)[Ljava/lang/Object;",
- executor_convert_basic_argument_id));
- RETURN_IF_ERROR(register_id("convertArrayArguments",
"(IZIIJJJJJ)[Ljava/lang/Object;",
- executor_convert_array_argument_id));
- RETURN_IF_ERROR(register_id("convertMapArguments",
"(IZIIJJJJJJJJ)[Ljava/lang/Object;",
- executor_convert_map_argument_id));
-
- RETURN_IF_ERROR(register_id("copyTupleBasicResult",
"(Ljava/lang/Object;IJJJJ)V",
- executor_copy_basic_result_id));
-
- RETURN_IF_ERROR(register_id("copyTupleArrayResult",
"(JZILjava/lang/Object;JJJJJ)V",
- executor_copy_array_result_id));
-
- RETURN_IF_ERROR(register_id("copyTupleMapResult",
"(JZILjava/lang/Object;JJJJJJJJ)V",
- executor_copy_map_result_id));
-
RETURN_IF_ERROR(
- register_id("addBatch", "(ZIIJI[Ljava/lang/Object;)V",
executor_add_batch_id));
+ register_id("addBatch", UDAF_EXECUTOR_ADD_SIGNATURE,
executor_add_batch_id));
return Status::OK();
}
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:199:**
previously declared here
```cpp
private:
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
