englefly commented on code in PR #25354:
URL: https://github.com/apache/doris/pull/25354#discussion_r1357641122
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Count.java:
##########
@@ -82,7 +82,7 @@ public void checkLegalityBeforeTypeCoercion() {
public void checkLegalityAfterRewrite() {
// after rewrite, count(distinct bitmap_column) should be rewritten to
bitmap_union_count(bitmap_column)
for (Expression argument : getArguments()) {
- if (argument.getDataType().isOnlyMetricType()) {
+ if (argument.getDataType().isObjectType()) {
throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
Review Comment:
the messge content (OnlyMetricTypeErrorMsg）should be updated
"Doris hll, bitmap, array, map, struct, jsonb, variant column must use ..."
array, map, struct, jsonb are not object type
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Count.java:
##########
@@ -82,7 +82,7 @@ public void checkLegalityBeforeTypeCoercion() {
public void checkLegalityAfterRewrite() {
// after rewrite, count(distinct bitmap_column) should be rewritten to
bitmap_union_count(bitmap_column)
for (Expression argument : getArguments()) {
- if (argument.getDataType().isOnlyMetricType()) {
+ if (argument.getDataType().isObjectType()) {
throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
Review Comment:
the messge content (OnlyMetricTypeErrorMsg）should be updated
"Doris hll, bitmap, array, map, struct, jsonb, variant column must use ..."
array, map, struct, jsonb are not object type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
