github-actions[bot] commented on code in PR #25278:
URL: https://github.com/apache/doris/pull/25278#discussion_r1357640403
##########
be/src/vec/common/hash_table/hash_map_context.h:
##########
@@ -126,6 +126,10 @@ struct MethodBase {
}
}
+ std::span<Key> get_keys() const { return {keys, hash_values.size()}; }
+
+ const size_t* get_hash_values() const { return hash_values.data(); }
Review Comment:
warning: function 'get_hash_values' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const size_t* get_hash_values() const { return
hash_values.data(); }
```
##########
be/src/vec/common/hash_table/hash_map_context.h:
##########
@@ -126,6 +126,10 @@ struct MethodBase {
}
}
+ std::span<Key> get_keys() const { return {keys, hash_values.size()}; }
Review Comment:
warning: function 'get_keys' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::span<Key> get_keys() const { return {keys,
hash_values.size()}; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
