github-actions[bot] commented on code in PR #25369:
URL: https://github.com/apache/doris/pull/25369#discussion_r1356654109
##########
be/src/vec/exec/join/vhash_join_node.h:
##########
@@ -450,13 +357,28 @@ class HashJoinNode final : public VJoinNodeBase {
return _runtime_filter_slots->ready_finish_publish();
}
+ bool have_other_join_conjunct() const { return _have_other_join_conjunct; }
Review Comment:
warning: function 'have_other_join_conjunct' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool have_other_join_conjunct() const { return
_have_other_join_conjunct; }
```
##########
be/src/vec/exec/join/vhash_join_node.h:
##########
@@ -450,13 +357,28 @@ class HashJoinNode final : public VJoinNodeBase {
return _runtime_filter_slots->ready_finish_publish();
}
+ bool have_other_join_conjunct() const { return _have_other_join_conjunct; }
+ bool is_right_semi_anti() const { return _is_right_semi_anti; }
Review Comment:
warning: function 'is_right_semi_anti' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_right_semi_anti() const { return
_is_right_semi_anti; }
```
##########
be/src/vec/exec/join/vhash_join_node.h:
##########
@@ -450,13 +357,28 @@ class HashJoinNode final : public VJoinNodeBase {
return _runtime_filter_slots->ready_finish_publish();
}
+ bool have_other_join_conjunct() const { return _have_other_join_conjunct; }
+ bool is_right_semi_anti() const { return _is_right_semi_anti; }
+ bool is_outer_join() const { return _is_outer_join; }
+ std::shared_ptr<std::vector<Block>> build_blocks() const { return
_build_blocks; }
+ Sizes probe_key_sz() const { return _probe_key_sz; }
Review Comment:
warning: function 'probe_key_sz' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] Sizes probe_key_sz() const { return _probe_key_sz; }
```
##########
be/src/vec/exec/join/vhash_join_node.h:
##########
@@ -450,13 +357,28 @@ class HashJoinNode final : public VJoinNodeBase {
return _runtime_filter_slots->ready_finish_publish();
}
+ bool have_other_join_conjunct() const { return _have_other_join_conjunct; }
+ bool is_right_semi_anti() const { return _is_right_semi_anti; }
+ bool is_outer_join() const { return _is_outer_join; }
Review Comment:
warning: function 'is_outer_join' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_outer_join() const { return _is_outer_join; }
```
##########
be/src/vec/exec/join/vhash_join_node.h:
##########
@@ -450,13 +357,28 @@ class HashJoinNode final : public VJoinNodeBase {
return _runtime_filter_slots->ready_finish_publish();
}
+ bool have_other_join_conjunct() const { return _have_other_join_conjunct; }
+ bool is_right_semi_anti() const { return _is_right_semi_anti; }
+ bool is_outer_join() const { return _is_outer_join; }
+ std::shared_ptr<std::vector<Block>> build_blocks() const { return
_build_blocks; }
+ Sizes probe_key_sz() const { return _probe_key_sz; }
+ std::vector<bool>* left_output_slot_flags() { return
&_left_output_slot_flags; }
+ std::vector<bool>* right_output_slot_flags() { return
&_right_output_slot_flags; }
+ bool* has_null_in_build_side() { return &_has_null_in_build_side; }
+ DataTypes right_table_data_types() { return _right_table_data_types; }
+ DataTypes left_table_data_types() { return _left_table_data_types; }
+ vectorized::Sizes& build_key_sz() { return _build_key_sz; }
+ bool build_unique() const { return _build_unique; }
Review Comment:
warning: function 'build_unique' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool build_unique() const { return _build_unique; }
```
##########
be/src/vec/exec/join/vhash_join_node.h:
##########
@@ -450,13 +357,28 @@ class HashJoinNode final : public VJoinNodeBase {
return _runtime_filter_slots->ready_finish_publish();
}
+ bool have_other_join_conjunct() const { return _have_other_join_conjunct; }
+ bool is_right_semi_anti() const { return _is_right_semi_anti; }
+ bool is_outer_join() const { return _is_outer_join; }
+ std::shared_ptr<std::vector<Block>> build_blocks() const { return
_build_blocks; }
Review Comment:
warning: function 'build_blocks' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::shared_ptr<std::vector<Block>> build_blocks() const {
return _build_blocks; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
