github-actions[bot] commented on code in PR #25369:
URL: https://github.com/apache/doris/pull/25369#discussion_r1356628958
##########
be/src/pipeline/exec/hashjoin_probe_operator.h:
##########
@@ -64,13 +81,25 @@ class HashJoinProbeLocalState final
SourceState& source_state,
vectorized::Block* temp_block,
bool check_rows_count = true);
- HashJoinProbeOperatorX* join_probe() { return
(HashJoinProbeOperatorX*)_parent; }
+ bool have_other_join_conjunct() const;
Review Comment:
warning: function 'have_other_join_conjunct' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool have_other_join_conjunct() const;
```
##########
be/src/pipeline/exec/hashjoin_build_sink.h:
##########
@@ -70,12 +70,25 @@ class HashJoinBuildSinkLocalState final
void init_short_circuit_for_probe();
HashJoinBuildSinkOperatorX* join_build() { return
(HashJoinBuildSinkOperatorX*)_parent; }
+ vectorized::Sizes& build_key_sz();
+ bool build_unique() const;
+ std::vector<TRuntimeFilterDesc>& runtime_filter_descs() const;
Review Comment:
warning: function 'runtime_filter_descs' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::vector<TRuntimeFilterDesc>& runtime_filter_descs()
const;
```
##########
be/src/pipeline/exec/hashjoin_build_sink.h:
##########
@@ -70,12 +70,25 @@ class HashJoinBuildSinkLocalState final
void init_short_circuit_for_probe();
HashJoinBuildSinkOperatorX* join_build() { return
(HashJoinBuildSinkOperatorX*)_parent; }
+ vectorized::Sizes& build_key_sz();
+ bool build_unique() const;
Review Comment:
warning: function 'build_unique' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool build_unique() const;
```
##########
be/src/pipeline/exec/hashjoin_probe_operator.h:
##########
@@ -64,13 +81,25 @@ class HashJoinProbeLocalState final
SourceState& source_state,
vectorized::Block* temp_block,
bool check_rows_count = true);
- HashJoinProbeOperatorX* join_probe() { return
(HashJoinProbeOperatorX*)_parent; }
+ bool have_other_join_conjunct() const;
+ bool is_right_semi_anti() const;
+ bool is_outer_join() const;
Review Comment:
warning: function 'is_outer_join' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_outer_join() const;
```
##########
be/src/pipeline/exec/hashjoin_probe_operator.h:
##########
@@ -64,13 +81,25 @@ class HashJoinProbeLocalState final
SourceState& source_state,
vectorized::Block* temp_block,
bool check_rows_count = true);
- HashJoinProbeOperatorX* join_probe() { return
(HashJoinProbeOperatorX*)_parent; }
+ bool have_other_join_conjunct() const;
+ bool is_right_semi_anti() const;
Review Comment:
warning: function 'is_right_semi_anti' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_right_semi_anti() const;
```
##########
be/src/pipeline/exec/hashjoin_probe_operator.h:
##########
@@ -64,13 +81,25 @@ class HashJoinProbeLocalState final
SourceState& source_state,
vectorized::Block* temp_block,
bool check_rows_count = true);
- HashJoinProbeOperatorX* join_probe() { return
(HashJoinProbeOperatorX*)_parent; }
+ bool have_other_join_conjunct() const;
+ bool is_right_semi_anti() const;
+ bool is_outer_join() const;
+ std::vector<bool>* left_output_slot_flags();
+ std::vector<bool>* right_output_slot_flags();
+ vectorized::DataTypes right_table_data_types();
+ vectorized::DataTypes left_table_data_types();
+ bool* has_null_in_build_side() { return
&_shared_state->_has_null_in_build_side; }
+ std::shared_ptr<std::vector<vectorized::Block>> build_blocks() const {
+ return _shared_state->build_blocks;
+ }
+ vectorized::Sizes probe_key_sz() const { return
_shared_state->probe_key_sz; }
Review Comment:
warning: function 'probe_key_sz' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] vectorized::Sizes probe_key_sz() const { return
_shared_state->probe_key_sz; }
```
##########
be/src/pipeline/exec/hashjoin_probe_operator.h:
##########
@@ -64,13 +81,25 @@ class HashJoinProbeLocalState final
SourceState& source_state,
vectorized::Block* temp_block,
bool check_rows_count = true);
- HashJoinProbeOperatorX* join_probe() { return
(HashJoinProbeOperatorX*)_parent; }
+ bool have_other_join_conjunct() const;
+ bool is_right_semi_anti() const;
+ bool is_outer_join() const;
+ std::vector<bool>* left_output_slot_flags();
+ std::vector<bool>* right_output_slot_flags();
+ vectorized::DataTypes right_table_data_types();
+ vectorized::DataTypes left_table_data_types();
+ bool* has_null_in_build_side() { return
&_shared_state->_has_null_in_build_side; }
+ std::shared_ptr<std::vector<vectorized::Block>> build_blocks() const {
Review Comment:
warning: function 'build_blocks' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::shared_ptr<std::vector<vectorized::Block>>
build_blocks() const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
