sdhzwc commented on code in PR #199:
URL:
https://github.com/apache/doris-flink-connector/pull/199#discussion_r1349637136
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java:
##########
@@ -41,18 +42,23 @@
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.HashMap;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Properties;
import java.util.regex.Pattern;
+import java.util.stream.Collectors;
public abstract class DatabaseSync {
private static final Logger LOG =
LoggerFactory.getLogger(DatabaseSync.class);
private static final String LIGHT_SCHEMA_CHANGE = "light_schema_change";
private static final String TABLE_NAME_OPTIONS = "table-name";
+ public static final String TABLE_DDL_TO_LOWER_CASE = "1";
+ public static final String TABLE_DDL_TO_UPPER_CASE = "2";
Review Comment:
> 我的意思是，这两者不应该被强硬地捆绑在一起。它们可以是一致的，也可以是不一致的。没有必要统一它们。
Okay, I can complete this operation by distinguishing between two fields.
Let me make some changes.
But multiple state representations cannot be completed through Boolean values
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java:
##########
@@ -41,18 +42,23 @@
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.HashMap;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Properties;
import java.util.regex.Pattern;
+import java.util.stream.Collectors;
public abstract class DatabaseSync {
private static final Logger LOG =
LoggerFactory.getLogger(DatabaseSync.class);
private static final String LIGHT_SCHEMA_CHANGE = "light_schema_change";
private static final String TABLE_NAME_OPTIONS = "table-name";
+ public static final String TABLE_DDL_TO_LOWER_CASE = "1";
+ public static final String TABLE_DDL_TO_UPPER_CASE = "2";
Review Comment:
> 我的意思是，这两者不应该被强硬地捆绑在一起。它们可以是一致的，也可以是不一致的。没有必要统一它们。
Okay, I can complete this operation by distinguishing between two fields.
Let me make some changes.
But multiple state representations cannot be completed through Boolean values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
