sdhzwc commented on code in PR #199:
URL:
https://github.com/apache/doris-flink-connector/pull/199#discussion_r1349438120
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java:
##########
@@ -41,18 +42,23 @@
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.HashMap;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Properties;
import java.util.regex.Pattern;
+import java.util.stream.Collectors;
public abstract class DatabaseSync {
private static final Logger LOG =
LoggerFactory.getLogger(DatabaseSync.class);
private static final String LIGHT_SCHEMA_CHANGE = "light_schema_change";
private static final String TABLE_NAME_OPTIONS = "table-name";
+ public static final String TABLE_DDL_TO_LOWER_CASE = "1";
+ public static final String TABLE_DDL_TO_UPPER_CASE = "2";
Review Comment:
> 也许添加一个布尔开关。如果它不区分大小写，则可以将其全部转换为小写。如果区分大小写，则保持原样。
I have figured out how to change everything else, but I found that Boolean
cannot express multiple meanings
As you said, either keep it the same or use all lowercase. If you convert it
all to uppercase, it won't be easy to achieve
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java:
##########
@@ -41,18 +42,23 @@
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.HashMap;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Properties;
import java.util.regex.Pattern;
+import java.util.stream.Collectors;
public abstract class DatabaseSync {
private static final Logger LOG =
LoggerFactory.getLogger(DatabaseSync.class);
private static final String LIGHT_SCHEMA_CHANGE = "light_schema_change";
private static final String TABLE_NAME_OPTIONS = "table-name";
+ public static final String TABLE_DDL_TO_LOWER_CASE = "1";
+ public static final String TABLE_DDL_TO_UPPER_CASE = "2";
Review Comment:
> 也许添加一个布尔开关。如果它不区分大小写，则可以将其全部转换为小写。如果区分大小写，则保持原样。
I have figured out how to change everything else, but I found that Boolean
cannot express multiple meanings
As you said, either keep it the same or use all lowercase. If you convert it
all to uppercase, it won't be easy to achieve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
