HappenLee commented on code in PR #24910:
URL: https://github.com/apache/doris/pull/24910#discussion_r1349617888
##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -651,20 +663,19 @@ Status
ProcessHashTableProbe<JoinOpType>::do_other_join_conjuncts(
}
if (is_mark_join) {
- auto& matched_map = assert_cast<ColumnVector<UInt8>&>(
-
*(output_block->get_by_position(orig_columns - 1)
- .column->assume_mutable()))
- .get_data();
+ auto mark_column =
+ output_block->get_by_position(orig_columns -
1).column->assume_mutable();
+ ColumnFilterHelper helper(*mark_column);
// For mark join, we only filter rows which have duplicate join
keys.
// And then, we set matched_map to the join result to do the mark
join's filtering.
for (size_t i = 1; i < row_count; ++i) {
if (!_same_to_prev[i]) {
- matched_map.push_back(filter_map[i - 1]);
+ helper.insert_value(filter_map[i - 1]);
Review Comment:
if match in have null value, maybe the result is not correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
