morrySnow commented on code in PR #24910:
URL: https://github.com/apache/doris/pull/24910#discussion_r1349452658
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -53,7 +53,7 @@
public class JoinUtils {
public static boolean couldShuffle(Join join) {
// Cross-join and Null-Aware-Left-Anti-Join only can be broadcast join.
- return !(join.getJoinType().isCrossJoin()) &&
!(join.getJoinType().isNullAwareLeftAntiJoin());
+ return !(join.getJoinType().isCrossJoin() ||
join.getJoinType().isNullAwareLeftAntiJoin() || join.isMarkJoin());
Review Comment:
add comment to explain why mark join cannot shuffle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
