yiguolei commented on code in PR #24964:
URL: https://github.com/apache/doris/pull/24964#discussion_r1339654422
##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -407,12 +407,14 @@ Status BlockReader::_unique_key_next_block(Block* block,
bool* eof) {
return Status::OK();
}
-void BlockReader::_insert_data_normal(MutableColumns& columns) {
+Status BlockReader::_insert_data_normal(MutableColumns& columns) {
auto block = _next_row.block.get();
- for (auto idx : _normal_columns_idx) {
+ RETURN_IF_CATCH_EXCEPTION(for (auto idx
Review Comment:
not catch the for loop
catch the insert from method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
