HappenLee commented on code in PR #24461:
URL: https://github.com/apache/doris/pull/24461#discussion_r1335569682
##########
be/src/vec/exec/join/vhash_join_node.h:
##########
@@ -215,19 +215,20 @@ struct ProcessHashTableBuild {
inserted_rows.reserve(_batch_size);
}
+ if constexpr
(ColumnsHashing::IsPreSerializedKeysHashMethodTraits<KeyGetter>::value) {
+ auto old_keys_memory = hash_table_ctx.keys_memory_usage;
+ hash_table_ctx.serialize_keys(_build_raw_ptrs, _rows);
+ key_getter.set_serialized_keys(hash_table_ctx.keys.data());
+
_join_context->_build_arena_memory_usage->add(hash_table_ctx.keys_memory_usage -
+ old_keys_memory);
+ }
+
_build_side_hash_values.resize(_rows);
auto& arena = *(_join_context->_arena);
auto old_build_arena_memory = arena.size();
+ auto keys = key_getter.get_keys(_rows);
Review Comment:
ref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
