HappenLee commented on code in PR #24461: URL: https://github.com/apache/doris/pull/24461#discussion_r1335569104
########## be/src/vec/exec/vpartition_sort_node.cpp: ########## @@ -112,20 +112,12 @@ void VPartitionSortNode::_emplace_into_hash_table(const ColumnRawPtrs& key_colum _pre_serialize_key_if_need(state, agg_method, key_columns, num_rows); //PHHashMap + auto keys = state.get_keys(num_rows); Review Comment: use reference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org