csun5285 commented on code in PR #24631:
URL: https://github.com/apache/doris/pull/24631#discussion_r1334318510


##########
be/src/vec/functions/function_json.cpp:
##########
@@ -526,6 +527,15 @@ struct GetJsonString {
                                         res_offsets);
         }
     }
+    static DataTypes get_variadic_argument_types_impl() {
+        if (std::is_same_v<ArgName1, DataTypeJsonb>) {
+            return {std::make_shared<DataTypeJsonb>(), 
std::make_shared<DataTypeString>()};

Review Comment:
   done



##########
be/src/vec/functions/function_json.cpp:
##########
@@ -876,7 +886,10 @@ class FunctionJson : public IFunction {
 using FunctionGetJsonDouble = 
FunctionBinaryStringOperateToNullType<GetJsonDouble>;
 using FunctionGetJsonInt = FunctionBinaryStringOperateToNullType<GetJsonInt>;
 using FunctionGetJsonBigInt = 
FunctionBinaryStringOperateToNullType<GetJsonBigInt>;
-using FunctionGetJsonString = 
FunctionBinaryStringOperateToNullType<GetJsonString>;
+using FunctionGetJsonStringImpl1 =

Review Comment:
   have removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to