xiaokang commented on code in PR #24631:
URL: https://github.com/apache/doris/pull/24631#discussion_r1333875835
##########
be/src/vec/functions/function_json.cpp:
##########
@@ -526,6 +527,15 @@ struct GetJsonString {
res_offsets);
}
}
+ static DataTypes get_variadic_argument_types_impl() {
+ if (std::is_same_v<ArgName1, DataTypeJsonb>) {
+ return {std::make_shared<DataTypeJsonb>(),
std::make_shared<DataTypeString>()};
Review Comment:
not necessary
##########
be/src/vec/functions/function.h:
##########
@@ -65,6 +65,11 @@ struct NullPresence {
bool has_null_constant = false;
};
+template <typename T>
+concept HasGetImpl = requires(T t) {
Review Comment:
HasGetVariadicArgumentTypesImpl
##########
be/src/vec/functions/function_jsonb.cpp:
##########
@@ -978,6 +986,10 @@ struct JsonbExtractDouble : public
JsonbExtractImpl<JsonbTypeDouble> {
struct JsonbExtractString : public JsonbExtractStringImpl<JsonbTypeString> {
static constexpr auto name = "json_extract_string";
static constexpr auto alias = "jsonb_extract_string";
+ static constexpr auto name2 = "get_json_string";
+ static DataTypes get_variadic_argument_types_impl() {
Review Comment:
process other get_json_xxx
##########
be/src/vec/functions/function_json.cpp:
##########
@@ -876,7 +886,10 @@ class FunctionJson : public IFunction {
using FunctionGetJsonDouble =
FunctionBinaryStringOperateToNullType<GetJsonDouble>;
using FunctionGetJsonInt = FunctionBinaryStringOperateToNullType<GetJsonInt>;
using FunctionGetJsonBigInt =
FunctionBinaryStringOperateToNullType<GetJsonBigInt>;
-using FunctionGetJsonString =
FunctionBinaryStringOperateToNullType<GetJsonString>;
+using FunctionGetJsonStringImpl1 =
Review Comment:
not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
