dataroaring commented on code in PR #24639: URL: https://github.com/apache/doris/pull/24639#discussion_r1330926170
########## be/src/olap/storage_engine.cpp: ########## @@ -1379,4 +1381,35 @@ void StorageEngine::evict_querying_rowset(RowsetId rs_id) { _querying_rowsets.erase(rs_id); } +bool StorageEngine::add_broken_path(std::string path) { + std::lock_guard<std::mutex> lock(_broken_paths_mutex); + auto success = _broken_paths.emplace(path).second; + if (success) { + _persist_broken_paths(); + } + return success; +} + +bool StorageEngine::remove_broken_path(std::string path) { + std::lock_guard<std::mutex> lock(_broken_paths_mutex); + auto count = _broken_paths.erase(path); + if (count > 1) { Review Comment: good catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org