github-actions[bot] commented on code in PR #24639:
URL: https://github.com/apache/doris/pull/24639#discussion_r1330265312
##########
be/test/olap/options_test.cpp:
##########
@@ -127,4 +127,74 @@ TEST_F(OptionsTest, parse_root_path) {
}
}
+TEST_F(OptionsTest, parse_conf_store_path) {
+ std::string path_prefix = std::filesystem::absolute("./test_run").string();
+ std::string path1 = path_prefix + "/palo";
+ std::string path2 = path_prefix + "/palo.ssd";
+
+ {
+ std::vector<StorePath> paths;
Review Comment:
warning: variable 'paths' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::vector<StorePath> paths = 0;
```
##########
be/test/olap/options_test.cpp:
##########
@@ -127,4 +127,74 @@
}
}
+TEST_F(OptionsTest, parse_conf_store_path) {
+ std::string path_prefix = std::filesystem::absolute("./test_run").string();
+ std::string path1 = path_prefix + "/palo";
+ std::string path2 = path_prefix + "/palo.ssd";
+
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), config_path.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";";
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), path1.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
Review Comment:
warning: variable 'paths' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::vector<StorePath> paths = 0;
```
##########
be/test/olap/options_test.cpp:
##########
@@ -127,4 +127,74 @@
}
}
+TEST_F(OptionsTest, parse_conf_store_path) {
+ std::string path_prefix = std::filesystem::absolute("./test_run").string();
+ std::string path1 = path_prefix + "/palo";
+ std::string path2 = path_prefix + "/palo.ssd";
+
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), config_path.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";";
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), path1.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";" + path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::Error<ErrorCode::INVALID_ARGUMENT>("a duplicated
path is found, path={}", path1), st);
+ }
+ {
+ std::vector<StorePath> paths;
Review Comment:
warning: variable 'paths' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::vector<StorePath> paths = 0;
```
##########
be/test/olap/options_test.cpp:
##########
@@ -127,4 +127,74 @@
}
}
+TEST_F(OptionsTest, parse_conf_store_path) {
+ std::string path_prefix = std::filesystem::absolute("./test_run").string();
+ std::string path1 = path_prefix + "/palo";
+ std::string path2 = path_prefix + "/palo.ssd";
+
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), config_path.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";";
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), path1.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";" + path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::Error<ErrorCode::INVALID_ARGUMENT>("a duplicated
path is found, path={}", path1), st);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";" + path2 + ";";
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 2);
+ EXPECT_STREQ(paths[0].path.c_str(), path1.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ EXPECT_STREQ(paths[1].path.c_str(), path2.c_str());
+ EXPECT_EQ(paths[1].capacity_bytes, -1);
+ EXPECT_EQ(paths[1].storage_medium, TStorageMedium::SSD);
+ }
+}
+
+TEST_F(OptionsTest, parse_broken_path) {
+ {
+ std::string broken_paths = "path1";
+ std::set<std::string> parsed_paths;
+ parse_conf_broken_store_paths(broken_paths, &parsed_paths);
+ EXPECT_EQ(parsed_paths.size(), 1);
+ }
+ {
+ std::string broken_paths = "path1;path1;";
+ std::set<std::string> parsed_paths;
+ parse_conf_broken_store_paths(broken_paths, &parsed_paths);
+ EXPECT_EQ(parsed_paths.size(), 1);
+ EXPECT_EQ(parsed_paths.count("path1"), 1);
+ }
+ {
+ std::string broken_paths = "path1;path2;";
+ std::set<std::string> parsed_paths;
Review Comment:
warning: variable 'parsed_paths' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::set<std::string> parsed_paths = 0;
```
##########
be/test/olap/options_test.cpp:
##########
@@ -127,4 +127,74 @@
}
}
+TEST_F(OptionsTest, parse_conf_store_path) {
+ std::string path_prefix = std::filesystem::absolute("./test_run").string();
+ std::string path1 = path_prefix + "/palo";
+ std::string path2 = path_prefix + "/palo.ssd";
+
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), config_path.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";";
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), path1.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";" + path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::Error<ErrorCode::INVALID_ARGUMENT>("a duplicated
path is found, path={}", path1), st);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";" + path2 + ";";
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 2);
+ EXPECT_STREQ(paths[0].path.c_str(), path1.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ EXPECT_STREQ(paths[1].path.c_str(), path2.c_str());
+ EXPECT_EQ(paths[1].capacity_bytes, -1);
+ EXPECT_EQ(paths[1].storage_medium, TStorageMedium::SSD);
+ }
+}
+
+TEST_F(OptionsTest, parse_broken_path) {
+ {
+ std::string broken_paths = "path1";
+ std::set<std::string> parsed_paths;
Review Comment:
warning: variable 'parsed_paths' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::set<std::string> parsed_paths = 0;
```
##########
be/test/olap/options_test.cpp:
##########
@@ -127,4 +127,74 @@
}
}
+TEST_F(OptionsTest, parse_conf_store_path) {
+ std::string path_prefix = std::filesystem::absolute("./test_run").string();
+ std::string path1 = path_prefix + "/palo";
+ std::string path2 = path_prefix + "/palo.ssd";
+
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), config_path.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";";
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), path1.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";" + path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::Error<ErrorCode::INVALID_ARGUMENT>("a duplicated
path is found, path={}", path1), st);
+ }
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1 + ";" + path2 + ";";
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 2);
+ EXPECT_STREQ(paths[0].path.c_str(), path1.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ EXPECT_STREQ(paths[1].path.c_str(), path2.c_str());
+ EXPECT_EQ(paths[1].capacity_bytes, -1);
+ EXPECT_EQ(paths[1].storage_medium, TStorageMedium::SSD);
+ }
+}
+
+TEST_F(OptionsTest, parse_broken_path) {
+ {
+ std::string broken_paths = "path1";
+ std::set<std::string> parsed_paths;
+ parse_conf_broken_store_paths(broken_paths, &parsed_paths);
+ EXPECT_EQ(parsed_paths.size(), 1);
+ }
+ {
+ std::string broken_paths = "path1;path1;";
+ std::set<std::string> parsed_paths;
Review Comment:
warning: variable 'parsed_paths' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::set<std::string> parsed_paths = 0;
```
##########
be/test/olap/options_test.cpp:
##########
@@ -127,4 +127,74 @@
}
}
+TEST_F(OptionsTest, parse_conf_store_path) {
+ std::string path_prefix = std::filesystem::absolute("./test_run").string();
+ std::string path1 = path_prefix + "/palo";
+ std::string path2 = path_prefix + "/palo.ssd";
+
+ {
+ std::vector<StorePath> paths;
+ std::string config_path = path1;
+ auto st = parse_conf_store_paths(config_path, &paths);
+ EXPECT_EQ(Status::OK(), st);
+ EXPECT_EQ(paths.size(), 1);
+ EXPECT_STREQ(paths[0].path.c_str(), config_path.c_str());
+ EXPECT_EQ(paths[0].capacity_bytes, -1);
+ EXPECT_EQ(paths[0].storage_medium, TStorageMedium::HDD);
+ }
+ {
+ std::vector<StorePath> paths;
Review Comment:
warning: variable 'paths' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::vector<StorePath> paths = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
