eldenmoon commented on code in PR #24170:
URL: https://github.com/apache/doris/pull/24170#discussion_r1324527096


##########
gensrc/proto/segment_v2.proto:
##########
@@ -162,6 +184,12 @@ message ColumnMetaPB {
     optional uint64 num_rows = 11;
     repeated string children_column_names = 12;
 
+    // persist info for PathInData that represents path in document, e.g. JSON.

Review Comment:
   comment already in ColumnPathInfo



##########
gensrc/proto/segment_v2.proto:
##########
@@ -162,6 +184,12 @@ message ColumnMetaPB {
     optional uint64 num_rows = 11;
     repeated string children_column_names = 12;
 
+    // persist info for PathInData that represents path in document, e.g. JSON.
+    optional ColumnPathInfo column_path_info = 13;
+
+    optional bytes default_value = 14; // ColumnMessage.default_value ?

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to