xiaokang commented on code in PR #24170:
URL: https://github.com/apache/doris/pull/24170#discussion_r1323859145
##########
gensrc/thrift/Descriptors.thrift:
##########
@@ -60,6 +60,8 @@ struct TSlotDescriptor {
// materialize them.Used to optmize to read less data and less memory usage
13: optional bool need_materialize = true
14: optional bool is_auto_increment = false;
+ // `$.a.b.c` => ['$', 'a', 'b', 'c']
Review Comment:
correct comment
##########
gensrc/proto/segment_v2.proto:
##########
@@ -162,6 +184,12 @@ message ColumnMetaPB {
optional uint64 num_rows = 11;
repeated string children_column_names = 12;
+ // persist info for PathInData that represents path in document, e.g. JSON.
Review Comment:
add comment to explain each extracted subcolumn of variant column will
generate a column in be schema
##########
gensrc/proto/olap_file.proto:
##########
@@ -206,6 +206,7 @@ message ColumnPB {
repeated ColumnPB children_columns = 17;
repeated string children_column_names = 18;
optional bool result_is_nullable = 19;
+ optional segment_v2.ColumnPathInfo column_path_info = 20;
Review Comment:
add comment to explain each extracted subcolumn of variant column will
generate a column in be schema
##########
gensrc/proto/segment_v2.proto:
##########
@@ -162,6 +184,12 @@ message ColumnMetaPB {
optional uint64 num_rows = 11;
repeated string children_column_names = 12;
+ // persist info for PathInData that represents path in document, e.g. JSON.
+ optional ColumnPathInfo column_path_info = 13;
+
+ optional bytes default_value = 14; // ColumnMessage.default_value ?
Review Comment:
add comment to explain why add them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
