zhannngchen commented on code in PR #21773: URL: https://github.com/apache/doris/pull/21773#discussion_r1323085495
########## fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java: ########## @@ -166,6 +166,8 @@ public class NativeInsertStmt extends InsertStmt { // true if be generates an insert from group commit tvf stmt and executes to load data public boolean isInnerGroupCommit = false; + private boolean isInsertIgnore = false; Review Comment: seems you missed some protection checks that 1. ignore mode only supports mow 2. ignore mode should not works with partial update pls correct me if I missed them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org