zhannngchen commented on code in PR #21773:
URL: https://github.com/apache/doris/pull/21773#discussion_r1323072957
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -131,7 +131,8 @@ Status BetaRowsetWriter::add_block(const vectorized::Block*
block) {
return _segment_creator.add_block(block);
}
-Status BetaRowsetWriter::_generate_delete_bitmap(int32_t segment_id) {
+Status BetaRowsetWriter::_generate_delete_bitmap(int32_t segment_id,
+ bool
is_unique_key_ignore_mode) {
Review Comment:
it's not necessary to add such additional parameter, you can use
`_context.tablet_schema->is_unique_key_ignore_mode()` directly at L153?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
