yiguolei commented on code in PR #24241:
URL: https://github.com/apache/doris/pull/24241#discussion_r1322758078
##########
be/src/vec/data_types/data_type_decimal.h:
##########
@@ -387,9 +387,9 @@ constexpr bool IsDataTypeDecimalOrNumber =
template <typename FromDataType, typename ToDataType>
requires IsDataTypeDecimal<FromDataType> && IsDataTypeDecimal<ToDataType>
-ToDataType::FieldType convert_decimals(const typename FromDataType::FieldType&
value,
- UInt32 scale_from, UInt32 scale_to,
- UInt8* overflow_flag = nullptr) {
+typename ToDataType::FieldType convert_decimals(const typename
FromDataType::FieldType& value,
Review Comment:
why add this??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
