yiguolei commented on code in PR #24241:
URL: https://github.com/apache/doris/pull/24241#discussion_r1322746953
##########
be/src/util/string_parser.hpp:
##########
@@ -714,9 +716,9 @@ T StringParser::string_to_decimal(const char* s, int len,
int type_precision, in
return 0;
}
*result = StringParser::PARSE_SUCCESS;
- value *= get_scale_multiplier<T>(type_scale - scale);
-
- return is_negative ? T(-value) : T(value);
+ if (type_scale > scale) {
+ value *= get_scale_multiplier<T>(type_scale - scale);
Review Comment:
missed return???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
