zhiqiang-hhhh commented on code in PR #24029:
URL: https://github.com/apache/doris/pull/24029#discussion_r1320921142
##########
be/src/service/doris_main.cpp:
##########
@@ -308,7 +307,6 @@ struct Checker {
int main(int argc, char** argv) {
doris::signal::InstallFailureSignalHandler();
- doris::init_signals();
// create StackTraceCache Instance, at the beginning, other static
destructors may use.
StackTrace::createCache();
Review Comment:
> The code is no longer needed, because ExecEnv manually `destroy()` at the
end of `main()`
>
> But there’s nothing wrong with keeping it
and it should be moved to bottom of jvm init, or jvm's signal handler for
sigint and sigterm will overwrite it
##########
be/src/service/doris_main.cpp:
##########
@@ -308,7 +307,6 @@ struct Checker {
int main(int argc, char** argv) {
doris::signal::InstallFailureSignalHandler();
- doris::init_signals();
// create StackTraceCache Instance, at the beginning, other static
destructors may use.
StackTrace::createCache();
Review Comment:
> The code is no longer needed, because ExecEnv manually `destroy()` at the
end of `main()`
>
> But there’s nothing wrong with keeping it
and it should be moved to bottom of jvm init, or jvm's signal handler for
sigint and sigterm will overwrite it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
