zhannngchen commented on code in PR #24011:
URL: https://github.com/apache/doris/pull/24011#discussion_r1318388024
##########
be/src/olap/tablet_meta.h:
##########
@@ -340,6 +340,13 @@ class DeleteBitmap {
constexpr static inline uint32_t ROWSET_SENTINEL_MARK =
std::numeric_limits<uint32_t>::max() - 1;
+ // When a delete bitmap is merged into tablet's delete bitmap, the version
of entries in the delete bitmap
+ // will be replaced to the correspoding correct version. So before we
finally merge a delete bitmap into
+ // tablet's delete bitmap we can use arbitary version number in BitmapKey.
Here we define some version numbers
+ // for specific usage during this periods to avoid conflicts
+ constexpr static inline uint64_t TEMP_VERSION_COMMON = 0;
Review Comment:
should also replace all 0 to `TEMP_VERSION_COMMON`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
