zhannngchen commented on code in PR #24011:
URL: https://github.com/apache/doris/pull/24011#discussion_r1318333149
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -447,6 +447,12 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
if (delete_sign_column_data != nullptr &&
delete_sign_column_data[block_pos] != 0) {
has_default_or_nullable = true;
use_default_or_null_flag.emplace_back(true);
+ if (!_tablet_schema->has_sequence_col() && !have_input_seq_column)
{
+ // we can directly use delete bitmap to mark the rows with
delete sign as deleted
+ // if sequence column doesn't exist to eliminate reading
delete sign columns in later reads
+ _mow_context->delete_bitmap->add({_opts.rowset_ctx->rowset_id,
_segment_id, 0},
Review Comment:
should use version 1 rather than 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
