xinyiZzz commented on code in PR #23578:
URL: https://github.com/apache/doris/pull/23578#discussion_r1310105977
##########
be/src/common/daemon.cpp:
##########
@@ -356,146 +354,59 @@ void Daemon::calculate_metrics_thread() {
DorisMetrics::instance()->all_segments_num->set_value(
StorageEngine::instance()->tablet_manager()->get_segment_nums());
}
- } while
(!_stop_background_threads_latch.wait_for(std::chrono::seconds(15)) &&
!k_doris_exit);
Review Comment:
All dependencies of `daemon` are constructed before `new daemon` and are
destroyed in stack order, so `daemon` does not need `k_doris_exit`, right?
but In the past `daemon.stop` is also before `ExecEnv::destroy`, but when BE
grace exit will be wrong: https://github.com/apache/doris/pull/22560
I'm not sure if there is still a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
