yiguolei commented on code in PR #23578:
URL: https://github.com/apache/doris/pull/23578#discussion_r1309576675


##########
be/src/service/http_service.cpp:
##########
@@ -63,7 +63,9 @@ HttpService::HttpService(ExecEnv* env, int port, int 
num_threads)
           _ev_http_server(new EvHttpServer(port, num_threads)),
           _web_page_handler(new WebPageHandler(_ev_http_server.get())) {}
 
-HttpService::~HttpService() {}
+HttpService::~HttpService() {
+    stop();

Review Comment:
   if the stop method is called inside this class. then it should be a prviate 
method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to