[GitHub] [doris] xingyingone commented on a diff in pull request #23474: [feature](agg) add the aggregation function 'array_agg'

[via GitHub]

xingyingone commented on code in PR #23474:
URL: https://github.com/apache/doris/pull/23474#discussion_r1308472070


##########
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##########
@@ -99,7 +99,8 @@ struct AggregateFunctionCollectSetData {
         read_var_int(max_size, buf);
     }
 
-    void insert_result_into(IColumn& to) const {
+    void insert_result_into(IColumn& to, bool shownull = false) const {
+        DCHECK(shownull == false);

Review Comment:
   you're right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org