xingyingone commented on code in PR #23474: URL: https://github.com/apache/doris/pull/23474#discussion_r1308470228
########## be/src/vec/aggregate_functions/aggregate_function_collect.h: ########## @@ -333,7 +378,12 @@ class AggregateFunctionCollect if constexpr (ENABLE_ARENA) { data.add(*columns[0], row_num, arena); } else { - data.add(*columns[0], row_num); + if (ShowNull::value && columns[0]->is_nullable()) { + auto& nullable_col = assert_cast<const ColumnNullable&>(*columns[0]); + data.add(nullable_col.get_nested_column(), row_num); Review Comment: I add more test data -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org