yiguolei commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1300805351
##########
be/src/olap/reader.cpp:
##########
@@ -616,9 +616,19 @@ Status TabletReader::_init_delete_condition(const
ReaderParams& read_params) {
((read_params.reader_type ==
ReaderType::READER_CUMULATIVE_COMPACTION &&
config::enable_delete_when_cumu_compaction)) ||
read_params.reader_type == ReaderType::READER_CHECKSUM);
-
+ if (_filter_delete) {
+ // note(tsy): for compaction, keep delete sub pred v1 temporarily
+ return _delete_handler.init(_tablet_schema,
read_params.delete_predicates,
+ read_params.version.second, false);
+ }
+ auto* runtime_state = read_params.runtime_state;
+ // note(tsy): for query, use session var to enable delete sub pred v2, for
schema change, use v2 directly
+ bool enable_sub_pred_v2 =
+ runtime_state == nullptr
+ ? true
+ :
runtime_state->query_options().enable_delete_sub_predicate_v2;
Review Comment:
add a method in runtime state --- enable_delete_predicate_v2()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
