yiguolei commented on code in PR #23237:
URL: https://github.com/apache/doris/pull/23237#discussion_r1300802233
##########
be/src/service/internal_service.cpp:
##########
@@ -1044,7 +1044,7 @@ void
PInternalServiceImpl::transmit_block(google::protobuf::RpcController* contr
}
FifoThreadPool& pool = request->has_block() ? _heavy_work_pool :
_light_work_pool;
- bool ret = pool.try_offer([this, controller, request, response, done]() {
+ bool ret = pool.offer([this, controller, request, response, done]() {
Review Comment:
maybe not right. BRPC thread will hang if the pool is full and there will be
many errors for networking stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
