yiguolei commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1299586630


##########
be/src/olap/data_dir.cpp:
##########
@@ -381,10 +382,19 @@ Status DataDir::load() {
         if (rowset_meta->is_local()) {
             rowset_meta->set_fs(local_fs);
         }
+        if (rowset_meta->has_delete_predicate()) {
+            auto* delete_pred = rowset_meta->mutable_delete_pred_pb();
+            if (!delete_pred->sub_predicates().empty() &&
+                delete_pred->sub_predicates_v2().empty()) {
+                DeleteHandler::convert_to_sub_pred_v2(delete_pred, 
rowset_meta->tablet_schema());
+                rowset_meta->serialize(result);

Review Comment:
   这里要加log,万一出错我们可以补救



##########
be/src/olap/data_dir.cpp:
##########
@@ -381,10 +382,19 @@ Status DataDir::load() {
         if (rowset_meta->is_local()) {
             rowset_meta->set_fs(local_fs);
         }
+        if (rowset_meta->has_delete_predicate()) {
+            auto* delete_pred = rowset_meta->mutable_delete_pred_pb();
+            if (!delete_pred->sub_predicates().empty() &&
+                delete_pred->sub_predicates_v2().empty()) {
+                DeleteHandler::convert_to_sub_pred_v2(delete_pred, 
rowset_meta->tablet_schema());
+                rowset_meta->serialize(result);

Review Comment:
   这里要加log,万一出错我们可以补救



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to