platoneko commented on code in PR #23072:
URL: https://github.com/apache/doris/pull/23072#discussion_r1297939696
##########
be/src/common/status.h:
##########
@@ -413,17 +424,6 @@ class Status {
bool ok() const { return _code == ErrorCode::OK; }
- bool is_io_error() const {
Review Comment:
I have checked these error code in `is_io_error`, replace `IO_ERROR` to
`TEST_FILE_ERROR`; removed `READ_UNENOUGH` as this error code is never used;
replace `CHECKSUM_ERROR` and `FILE_DATA_ERROR` to `INTERNAL_ERROR` as such 2
error code are only used in meta header file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
