yiguolei commented on code in PR #23072:
URL: https://github.com/apache/doris/pull/23072#discussion_r1296579287
##########
be/src/http/action/download_action.cpp:
##########
@@ -68,7 +69,7 @@ void DownloadAction::handle_normal(HttpRequest* req, const
std::string& file_par
status = check_token(req);
if (!status.ok()) {
std::string error_msg = status.to_string();
- if (status.is_not_authorized()) {
Review Comment:
we should remove these method:
bool is_invalid_argument() const { return ErrorCode::INVALID_ARGUMENT ==
_code; }
bool is_not_found() const { return _code == ErrorCode::NOT_FOUND; }
bool is_not_authorized() const { return code() ==
TStatusCode::NOT_AUTHORIZED; }
I think only IO ERROR should has method is_io_error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
