TangSiyang2001 commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1296559135
##########
be/src/olap/data_dir.cpp:
##########
@@ -373,6 +375,14 @@ Status DataDir::load() {
const std::string& meta_str) -> bool {
RowsetMetaSharedPtr rowset_meta(new RowsetMeta());
bool parsed = rowset_meta->init(meta_str);
+ // convert delete predicate to v2 (#22442)
+ if (rowset_meta->has_delete_predicate()) {
Review Comment:
ok, actually I'm thinking how to write back in one traverse with least
change, our rowset meta traverse is under read semantics.
##########
be/src/olap/data_dir.cpp:
##########
@@ -373,6 +375,14 @@ Status DataDir::load() {
const std::string& meta_str) -> bool {
RowsetMetaSharedPtr rowset_meta(new RowsetMeta());
bool parsed = rowset_meta->init(meta_str);
+ // convert delete predicate to v2 (#22442)
+ if (rowset_meta->has_delete_predicate()) {
Review Comment:
ok, actually I'm thinking about how to write back in one traverse with least
change, our rowset meta traverse is under read semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
