zhannngchen commented on code in PR #22984:
URL: https://github.com/apache/doris/pull/22984#discussion_r1294628958


##########
be/src/olap/tablet.cpp:
##########
@@ -3340,8 +3344,8 @@ Status Tablet::update_delete_bitmap(const 
RowsetSharedPtr& rowset,
     if (config::enable_merge_on_write_correctness_check && rowset->num_rows() 
!= 0) {
         // only do correctness check if the rowset has at least one row written
         // check if all the rowset has ROWSET_SENTINEL_MARK
-        RETURN_IF_ERROR(
-                _check_delete_bitmap_correctness(delete_bitmap, cur_version - 
1, cur_rowset_ids));
+        RETURN_IF_ERROR(_check_delete_bitmap_correctness(delete_bitmap, 
cur_version - 1, txn_id,
+                                                         cur_rowset_ids, 
specified_rowsets, false));

Review Comment:
   This `specified_rowsets` is not the rowsets corresponding to `cur_rowset_ids`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to