zhannngchen commented on code in PR #22984:
URL: https://github.com/apache/doris/pull/22984#discussion_r1294417345
##########
be/src/olap/tablet.h:
##########
@@ -301,8 +301,17 @@ class Tablet : public BaseTablet {
// caller should hold the _meta_lock before calling this method
void generate_tablet_meta_copy_unlocked(TabletMetaSharedPtr
new_tablet_meta) const;
+ void extract_rowsets_unlocked(std::vector<RowsetSharedPtr>& rowsets);
Review Comment:
These methods should be private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
