yiguolei commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1295698595
##########
be/src/olap/reader.cpp:
##########
@@ -616,9 +616,13 @@ Status TabletReader::_init_delete_condition(const
ReaderParams& read_params) {
((read_params.reader_type ==
ReaderType::READER_CUMULATIVE_COMPACTION &&
config::enable_delete_when_cumu_compaction)) ||
read_params.reader_type == ReaderType::READER_CHECKSUM);
-
- return _delete_handler.init(_tablet_schema, read_params.delete_predicates,
- read_params.version.second);
+ if (_filter_delete) {
+ return _delete_handler.init<false>(_tablet_schema,
read_params.delete_predicates,
Review Comment:
这种地方就不要用模板了，意义不大
##########
be/src/olap/reader.cpp:
##########
@@ -616,9 +616,13 @@ Status TabletReader::_init_delete_condition(const
ReaderParams& read_params) {
((read_params.reader_type ==
ReaderType::READER_CUMULATIVE_COMPACTION &&
config::enable_delete_when_cumu_compaction)) ||
read_params.reader_type == ReaderType::READER_CHECKSUM);
-
- return _delete_handler.init(_tablet_schema, read_params.delete_predicates,
- read_params.version.second);
+ if (_filter_delete) {
+ return _delete_handler.init<false>(_tablet_schema,
read_params.delete_predicates,
Review Comment:
这种地方就不要用模板了，意义不大
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
