ucasfl commented on code in PR #22801:
URL: https://github.com/apache/doris/pull/22801#discussion_r1292021476
##########
be/src/vec/core/decimal_comparison.h:
##########
@@ -135,8 +135,8 @@ class DecimalComparison {
}
template <typename T, typename U>
- static std::enable_if_t<IsDecimalNumber<T> && IsDecimalNumber<U>, Shift>
getScales(
- const DataTypePtr& left_type, const DataTypePtr& right_type) {
+ requires IsDecimalNumber<T> && IsDecimalNumber<U>
Review Comment:
Unneed, just need `()` when having `!`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
