yiguolei commented on code in PR #22801:
URL: https://github.com/apache/doris/pull/22801#discussion_r1292008022
##########
be/src/vec/data_types/data_type_decimal.h:
##########
@@ -407,10 +407,10 @@ constexpr bool IsDataTypeDecimalOrNumber =
IsDataTypeDecimal<DataType> || IsDataTypeNumber<DataType>;
template <typename FromDataType, typename ToDataType>
-std::enable_if_t<IsDataTypeDecimal<FromDataType> &&
IsDataTypeDecimal<ToDataType>,
- typename ToDataType::FieldType>
-convert_decimals(const typename FromDataType::FieldType& value, UInt32
scale_from, UInt32 scale_to,
- UInt8* overflow_flag = nullptr) {
+ requires IsDataTypeDecimal<FromDataType> && IsDataTypeDecimal<ToDataType>
Review Comment:
requires () ?
##########
be/src/vec/data_types/data_type_decimal.h:
##########
@@ -534,9 +534,9 @@ void convert_decimal_cols(
}
template <typename FromDataType, typename ToDataType>
-std::enable_if_t<IsDataTypeDecimal<FromDataType> &&
IsDataTypeNumber<ToDataType>,
- typename ToDataType::FieldType>
-convert_from_decimal(const typename FromDataType::FieldType& value, UInt32
scale) {
+ requires IsDataTypeDecimal<FromDataType> && IsDataTypeNumber<ToDataType>
Review Comment:
requires ()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
