amorynan commented on code in PR #22793:
URL: https://github.com/apache/doris/pull/22793#discussion_r1289495470
##########
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:
##########
@@ -123,25 +123,13 @@ Status ParquetColumnReader::create(io::FileReaderSPtr
file, FieldSchema* field,
size_t max_buf_size) {
if (field->type.type == TYPE_ARRAY) {
std::unique_ptr<ParquetColumnReader> element_reader;
- if (field->children[0].type.type == TYPE_MAP ||
- field->children[0].type.type == TYPE_STRUCT) {
- return Status::InternalError(
- "Array does not support nested map/struct type in column
{}", field->name);
- }
RETURN_IF_ERROR(create(file, &field->children[0], row_group,
row_ranges, ctz, io_ctx,
element_reader, max_buf_size));
element_reader->set_nested_column();
- ArrayColumnReader* array_reader = new ArrayColumnReader(row_ranges,
ctz, io_ctx);
+ auto array_reader = ArrayColumnReader::create_unique(row_ranges, ctz,
io_ctx);
RETURN_IF_ERROR(array_reader->init(std::move(element_reader), field));
- reader.reset(array_reader);
+ reader.reset();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
