airborne12 commented on code in PR #22793:
URL: https://github.com/apache/doris/pull/22793#discussion_r1289464472
##########
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:
##########
@@ -150,31 +138,23 @@ Status ParquetColumnReader::create(io::FileReaderSPtr
file, FieldSchema* field,
io_ctx, value_reader, max_buf_size));
key_reader->set_nested_column();
value_reader->set_nested_column();
- MapColumnReader* map_reader = new MapColumnReader(row_ranges, ctz,
io_ctx);
+ auto map_reader = MapColumnReader::create_unique(row_ranges, ctz,
io_ctx);
RETURN_IF_ERROR(map_reader->init(std::move(key_reader),
std::move(value_reader), field));
- reader.reset(map_reader);
} else if (field->type.type == TYPE_STRUCT) {
std::vector<std::unique_ptr<ParquetColumnReader>> child_readers;
for (int i = 0; i < field->children.size(); ++i) {
- auto child_type = field->children[i].type.type;
- if (child_type == TYPE_ARRAY || child_type == TYPE_MAP ||
child_type == TYPE_STRUCT) {
- return Status::InternalError(
- "Struct does not support nested complex type in column
{}", field->name);
- }
std::unique_ptr<ParquetColumnReader> child_reader;
RETURN_IF_ERROR(create(file, &field->children[i], row_group,
row_ranges, ctz, io_ctx,
child_reader, max_buf_size));
child_reader->set_nested_column();
child_readers.emplace_back(std::move(child_reader));
Review Comment:
for efficient memory allocate, may be the following is better
```
child_readers.reserve(field->children.size());
for (auto& child : field->children) {
auto child_reader = std::make_unique<ParquetColumnReader>();
RETURN_IF_ERROR(create(file, &field->children[i], row_group, row_ranges,
ctz, io_ctx,
child_reader, max_buf_size));
child_reader->set_nested_column();
child_readers.emplace_back(std::move(child_reader));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
