colordove edited a comment on issue #4308: URL: https://github.com/apache/incubator-doris/issues/4308#issuecomment-671784028
> Nice Job! > > Just have had a quick tour of the code, and some tips here could be of help: > > * Precompiled css frameworks like `sass` `stylus` `less` might be better for a theme customization? > * Replace some `px` with `rem` might be better for the future responsive development? > * Use `mixin` for all pages that have a paginated table, instead of setting the same code in every page? > * A more detailed `eslint` configuration file? > * Using `jwt` or `session` instead of `basic auth` as an authentication method? > * Currently lack of multi-languages neither in the frontend nor the backend? > * Make an integration with `Swagger` to have a better API document maybe? > > Actually there is a nice frontend template that we can refer to [vue-element-admin](https://github.com/PanJiaChen/vue-element-admin) Thank you for your advice! We were really inspired by it. But I don't understand what is lack of multi-languages means. Why we need multi-languages? We want to rewrite the frontend page in the future. We want to use React instead of Vue. **Here are some reasons.** - Vue3.x is at release candidate stage. It has a lot of breaking changes from the 2.x, If we use Vue 2.x, We have to rewrite it again in the future which is we don't want to do. - Vue2.x is not working very well with TypeScript, TypeScript is important and it's future. **Here is the skill set we want to looks like** - React - TypeScript - Less - Eslint - Webpack - RxJS - Antd In my opinion - `rem` or `px` is ok - Paginate related code could be a `react hooks`, like `usePaginate`. - OAuth and Swagger are great ideas. I think we can consider whether to add them to our code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
