hffariel commented on issue #4308: URL: https://github.com/apache/incubator-doris/issues/4308#issuecomment-671760831
Nice Job! Just have had a quick tour of the code, and some tips here could be of help: - Precompiled css frameworks like `sass` `stylus` `less` might be better for a theme customization? - Replace some `px` with `rem` might be better for the future responsive development? - Use `mixin` for all pages that have a paginated table, instead of setting the same code in every page? - A more detailed `eslint` configuration file? - Using `jwt` or `session` instead of `basic auth` as an authentication method? - Currently lack of multi-languages neither in the frontend nor the backend? - Make an integration with `Swagger` to have a better API document maybe? Actually there is a nice frontend template that we can refer to [vue-element-admin](https://github.com/PanJiaChen/vue-element-admin) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
