hubgeter commented on code in PR #22115:
URL: https://github.com/apache/doris/pull/22115#discussion_r1271710265
##########
be/src/vec/exec/format/parquet/vparquet_reader.cpp:
##########
@@ -511,6 +511,34 @@ Status
ParquetReader::get_columns(std::unordered_map<std::string, TypeDescriptor
return Status::OK();
}
+Status ParquetReader::get_next_block(Block* block, size_t* read_rows, bool*
eof,
+ TPushAggOp::type push_down_agg_type_opt) {
+ if (push_down_agg_type_opt != TPushAggOp::type::COUNT) {
+ return Status::NotSupported("min/max push down is not supported for
parquet files");
+ }
+ size_t rows = 0;
+
+ // out of use _t_metadata->num_rows , because for the same file,
+ // the optimizer may generate multiple VFileScanner with different
_scan_range
+ while (_read_row_groups.size() > 0) {
+ _next_row_group_reader();
+ rows += _current_group_reader->get__remaining_rows();
+ }
+
+ //fill one column is enough
+ auto cols = block->mutate_columns();
+ for (auto& col : cols) {
+ col->resize(rows);
Review Comment:
good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
