hubgeter commented on code in PR #22115:
URL: https://github.com/apache/doris/pull/22115#discussion_r1271709577
##########
be/src/vec/exec/format/generic_reader.h:
##########
@@ -31,6 +31,12 @@ class Block;
class GenericReader {
public:
virtual Status get_next_block(Block* block, size_t* read_rows, bool* eof)
= 0;
+
+ virtual Status get_next_block(Block* block, size_t* read_rows, bool* eof,
Review Comment:
good idea , but i need append parameter `TPushAggOp::type
push_down_agg_type_opt ` to all `get_next_block` functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
