[GitHub] [doris] yiguolei commented on a diff in pull request #21906: [Bug][Colocate] when adding a table to the colocate group, we should check that the number of buckets per partition is the same

[via GitHub]

yiguolei commented on code in PR #21906:
URL: https://github.com/apache/doris/pull/21906#discussion_r1266900349


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -2138,7 +2138,7 @@ private void createOlapTable(Database db, CreateTableStmt 
stmt) throws UserExcep
                 ColocateGroupSchema groupSchema = 
Env.getCurrentColocateIndex().getGroupSchema(fullGroupName);
                 if (groupSchema != null) {
                     // group already exist, check if this table can be added 
to this group
-                    groupSchema.checkColocateSchema(olapTable);
+                    groupSchema.checkColocateSchema(olapTable, false);
                     groupSchema.checkDynamicPartition(properties, 
olapTable.getDefaultDistributionInfo());

Review Comment:
   and here, pls add comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org