yiguolei commented on code in PR #21906:
URL: https://github.com/apache/doris/pull/21906#discussion_r1266900039
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -4042,7 +4042,7 @@ public void modifyTableColocate(Database db, OlapTable
table, String assignedGro
}
} else {
// set to an already exist colocate group, check if this table
can be added to this group.
- groupSchema.checkColocateSchema(table);
Review Comment:
why not check all partitions in this case?
And please add comment here , or other people will not know the reason and
may delete it during refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
