yiguolei commented on code in PR #21334:
URL: https://github.com/apache/doris/pull/21334#discussion_r1247305303
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -271,6 +271,69 @@ void ColumnArray::update_hash_with_value(size_t n,
SipHash& hash) const {
for (size_t i = 0; i < array_size; ++i)
get_data().update_hash_with_value(offset + i, hash);
}
+void ColumnArray::update_hashes_with_value(std::vector<SipHash>& hashes,
+ const uint8_t* __restrict
null_data) const {
+ SIP_HASHES_FUNCTION_COLUMN_IMPL();
+}
+
+// for every array row calculate xxHash
+void ColumnArray::update_xxHash_with_value(size_t n, uint64_t& hash) const {
+ size_t elem_size = size_at(n);
Review Comment:
我感觉这个逻辑不对啊，比如 [[1,1,1], [2,2,2,2], [3]] 这个带nested的array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
