yiguolei commented on code in PR #21334:
URL: https://github.com/apache/doris/pull/21334#discussion_r1247304348
##########
be/src/vec/sink/vdata_stream_sender.cpp:
##########
@@ -629,7 +630,8 @@ Status VDataStreamSender::send(RuntimeState* state, Block*
block, bool eos) {
std::vector<SipHash> siphashs(rows);
// result[j] means column index, i means rows index
for (int j = 0; j < result_size; ++j) {
-
block->get_by_position(result[j]).column->update_hashes_with_value(siphashs);
+ unpack_if_const(block->get_by_position(result[j]).column)
Review Comment:
add some comment here, to explain whey do we need uppack const column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
